This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Support for CLI configuration in an external JSON file #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Finally, there's support for storing a complex configuration in an external | ||
| JSON file, using `--config <file>`. Any of the options from the file can be | ||
| overridden via a command-line flag. For example, | ||
|
|
There was a problem hiding this comment.
Perhaps include a very basic snippet of what the config file would look like. I just find it easier to grok what it means with an example.
|
A couple of nits and a suggestion you might disagree with :) Looks like the code does the right thing, though. |
|
Thanks for the review! I'm going to merge. |
jeffposnick
added a commit
that referenced
this pull request
Feb 10, 2016
Support for CLI configuration in an external JSON file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface @wibblymat
I can see this as being useful for developers who prefer the CLI and want a reasonable way of specifying options, other than having to provide them all as command line flags.
It supports overriding the config file options with additional flags, making it easy to have, e.g., a
devbuild with--no-handle-fetchand--verboseset.Closes #79